Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore dependabot in DCO check #4549

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 5, 2024

Description

Dependabot adds proper sign-offs to its commits. However, the DCO check is very picky: it wants the sign-off and the GitHub username email to match. This is not the case for dependabot. So exclude dependabot from it.

Fixes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Dependabot adds proper sign-offs to its commits. However, the DCO check
is _very_ picky: it wants the sign-off and the GitHub username email to
match. This is not the case for dependabot. So exclude dependabot from
it.

Fixes: dae9c6b ("Add GitHub Workflow based DCO check")
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 added bug Something isn't working area/ci labels Jun 5, 2024
@twz123 twz123 requested a review from a team as a code owner June 5, 2024 13:59
@twz123 twz123 requested review from kke and juanluisvaladas June 5, 2024 13:59
@twz123 twz123 merged commit 7361e2e into k0sproject:main Jun 5, 2024
80 checks passed
@twz123 twz123 deleted the dco-ignore-dependabot branch June 5, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants