Autodetect the k0s APIs to be built #4536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twz123
force-pushed
the
autodetect-api-group-versions
branch
4 times, most recently
from
191d66a to
1503628
Compare
jnummelin
approved these changes
Jun 4, 2024
Tests and auto-generated files don't need to trigger rebuilds. Signed-off-by: Tom Wieczorek <[email protected]>
The CRD component is always used with a single bundle directory, so there's no need to support multiple bundle directories in the same component via slices and loops. Call sites can also very well use the CRD component itself multiple times if they need to handle multiple bundles. Signed-off-by: Tom Wieczorek <[email protected]>
So that the asset dir and the bundle name may be different. Signed-off-by: Tom Wieczorek <[email protected]>
Makes the gen_output_dir variable superfluous. Signed-off-by: Tom Wieczorek <[email protected]>
This allows for adding new APIs and API versions without the need to touch the Makefile. Whenever a new `pkg/apis/foo/version` folder gets added, it will be built automatically. Signed-off-by: Tom Wieczorek <[email protected]>
twz123
force-pushed
the
autodetect-api-group-versions
branch
from
1503628 to
31aadb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows for adding new APIs and API versions without the need to touch the Makefile. Whenever a new
pkg/apis/foo/versionfolder gets added, it will be built automatically.This required code generation to behave the same for all API group versions. The special case of the k0s CRD output directory has been normalized from
v1beta1tok0s. To make this transparent to k0s users, the CRD bundle files written to disk retain thev1beta1prefix.See:
Type of change
How Has This Been Tested?
Checklist: