Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use register-gen to generate schema registration boilerplate #4535

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 3, 2024

Description

Replace the handwritten stuff with that.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added the chore label Jun 3, 2024
@twz123 twz123 marked this pull request as ready for review June 3, 2024 17:46
@twz123 twz123 requested a review from a team as a code owner June 3, 2024 17:46
@twz123 twz123 requested review from ncopa and juanluisvaladas June 3, 2024 17:46
@twz123 twz123 force-pushed the register-gen branch 5 times, most recently from 0d537ba to c5066de Compare June 4, 2024 13:12
jnummelin
jnummelin previously approved these changes Jun 4, 2024
@twz123 twz123 dismissed jnummelin’s stale review June 5, 2024 14:00

The merge-base changed after approval.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

This pull request has merge conflicts that need to be resolved.

Replace the handwritten stuff with that.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123
Copy link
Member Author

twz123 commented Jun 6, 2024

This is basically creating zz_generated.register.go files for each API version using this template: https://github.com/kubernetes/kubernetes/blob/v1.30.1/staging/src/k8s.io/code-generator/cmd/register-gen/generators/register_external.go#L75-L116.

@twz123 twz123 merged commit 249334c into k0sproject:main Jun 7, 2024
78 checks passed
@twz123 twz123 deleted the register-gen branch June 7, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants