Construct Helm actions using Helm env helpers #4515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we get the retrying round-tripper setup and Helm now retries some known transient errors such as the etcd leader change. Fixes k0sproject#3758 Signed-off-by: Jussi Nummelin <[email protected]>
twz123
reviewed
May 29, 2024
| @@ -76,6 +78,14 @@ func NewCommands(k0sVars *config.CfgVars) *Commands { | |||
| } | |||
|
|
|||
| func (hc *Commands) getActionCfg(namespace string) (*action.Configuration, error) { | |||
| // Construct new helm env so we get the retrying roundtripper etc. setup | |||
| // See https://github.com/helm/helm/pull/11426/commits/b5378b3a5dd435e5c364ac0cfa717112ad686bd0 | |||
There was a problem hiding this comment.
We could also include a link to the request to make the retrying roundtripper public: helm/helm#13052.
If that's public, we could even consider to use this in k0s's kube clients as well 🤔
And we could add this depending whether we use etcd or not.
twz123
approved these changes
May 29, 2024
jnummelin
added
backport/release-1.27
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This way we get the retrying round-tripper setup and Helm now retries some known transient errors such as the etcd leader change.
Fixes #3758
Type of change
How Has This Been Tested?
Checklist: