Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests around k0s reset #4238

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Add integration tests around k0s reset #4238

merged 1 commit into from
Apr 5, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Apr 4, 2024

Description

Have a "full-fledged" integration test called reset which should cover all aspects of k0s reset for the default CRI. Also add a check to byocri to verify that k0s reset terminates the Docker containers.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Add integration tests around k0s reset
9237a87 
Have a "full-fledged" integration test called reset which should cover
all aspects of k0s reset for the default CRI. Also add a check to byocri
to verify that k0s reset terminates the Docker containers.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 marked this pull request as ready for review April 5, 2024 07:40
@twz123 twz123 requested a review from a team as a code owner April 5, 2024 07:40
@twz123 twz123 requested review from ncopa and juanluisvaladas April 5, 2024 07:40
@twz123 twz123 merged commit f660c1b into k0sproject:main Apr 5, 2024
75 checks passed
@twz123 twz123 deleted the reset-inttests branch April 5, 2024 16:42
@twz123 twz123 added the backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch label Dec 11, 2024
@twz123
Copy link
Member Author

twz123 commented Dec 11, 2024

Another backport for #5300

@k0s-bot
Copy link

k0s-bot commented Dec 11, 2024

Successfully created backport PR for release-1.29:

@k0s-bot k0s-bot mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makhov makhov makhov approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas juanluisvaladas is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
area/smoke-tests backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twz123 @k0s-bot @makhov