Provide several sub-commands only on Linux

They won't work on non-Linux systems anyways.

Use build flags to add platform-specific sub-commands instead of runtime
checks. Also add build tag to files that only make sense on specific
platforms.

Signed-off-by: Tom Wieczorek <[email protected]>

cmd/install/controller.go

@@ -1,3 +1,5 @@
+//go:build linux
+
 /*
 Copyright 2021 k0s authors
 

cmd/install/controller_test.go

@@ -1,3 +1,5 @@
+//go:build linux
+
 /*
 Copyright 2024 k0s authors
 

cmd/install/install.go

@@ -1,3 +1,5 @@
+//go:build linux
+
 /*
 Copyright 2021 k0s authors
 

cmd/install/worker.go

@@ -1,3 +1,5 @@
+//go:build linux
+
 /*
 Copyright 2021 k0s authors
 

cmd/reset/reset.go

@@ -1,3 +1,5 @@
+//go:build unix
+
 /*
 Copyright 2021 k0s authors
 

cmd/root.go

@@ -20,23 +20,15 @@ import (
 	"errors"
 	"net/http"
 	"os"
-	"runtime"
 
 	"github.com/k0sproject/k0s/cmd/airgap"
 	"github.com/k0sproject/k0s/cmd/api"
-	"github.com/k0sproject/k0s/cmd/backup"
 	configcmd "github.com/k0sproject/k0s/cmd/config"
 	"github.com/k0sproject/k0s/cmd/controller"
 	"github.com/k0sproject/k0s/cmd/ctr"
 	"github.com/k0sproject/k0s/cmd/etcd"
-	"github.com/k0sproject/k0s/cmd/install"
 	"github.com/k0sproject/k0s/cmd/kubeconfig"
 	"github.com/k0sproject/k0s/cmd/kubectl"
-	"github.com/k0sproject/k0s/cmd/reset"
-	"github.com/k0sproject/k0s/cmd/restore"
-	"github.com/k0sproject/k0s/cmd/start"
-	"github.com/k0sproject/k0s/cmd/status"
-	"github.com/k0sproject/k0s/cmd/stop"
 	"github.com/k0sproject/k0s/cmd/sysinfo"
 	"github.com/k0sproject/k0s/cmd/token"
 	"github.com/k0sproject/k0s/cmd/validate"
@@ -83,25 +75,12 @@ func NewRootCmd() *cobra.Command {
 
 	cmd.AddCommand(airgap.NewAirgapCmd())
 	cmd.AddCommand(api.NewAPICmd())
-	cmd.AddCommand(backup.NewBackupCmd())
 	cmd.AddCommand(controller.NewControllerCmd())
 	cmd.AddCommand(ctr.NewCtrCommand())
 	cmd.AddCommand(configcmd.NewConfigCmd())
 	cmd.AddCommand(etcd.NewEtcdCmd())
-	cmd.AddCommand(install.NewInstallCmd())
 	cmd.AddCommand(kubeconfig.NewKubeConfigCmd())
 	cmd.AddCommand(kubectl.NewK0sKubectlCmd())
-	if runtime.GOOS == "linux" {
-		// Currently only supported on Linux
-		cmd.AddCommand(reset.NewResetCmd())
-	}
-	cmd.AddCommand(restore.NewRestoreCmd())
-	cmd.AddCommand(start.NewStartCmd())
-	if runtime.GOOS == "linux" {
-		// Currently only supported on Linux
-		cmd.AddCommand(status.NewStatusCmd())
-	}
-	cmd.AddCommand(stop.NewStopCmd())
 	cmd.AddCommand(sysinfo.NewSysinfoCmd())
 	cmd.AddCommand(token.NewTokenCmd())
 	cmd.AddCommand(validate.NewValidateCmd()) // hidden+deprecated
@@ -112,6 +91,8 @@ func NewRootCmd() *cobra.Command {
 	cmd.AddCommand(newDefaultConfigCmd()) // hidden+deprecated
 	cmd.AddCommand(newDocsCmd())
 
+	addPlatformSpecificCommands(cmd)
+
 	cmd.DisableAutoGenTag = true
 	longDesc = "k0s - The zero friction Kubernetes - https://k0sproject.io"
 	if build.EulaNotice != "" {

cmd/root_linux.go

@@ -0,0 +1,39 @@
+/*
+Copyright 2024 k0s authors
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package cmd
+
+import (
+	"github.com/k0sproject/k0s/cmd/backup"
+	"github.com/k0sproject/k0s/cmd/install"
+	"github.com/k0sproject/k0s/cmd/reset"
+	"github.com/k0sproject/k0s/cmd/restore"
+	"github.com/k0sproject/k0s/cmd/start"
+	"github.com/k0sproject/k0s/cmd/status"
+	"github.com/k0sproject/k0s/cmd/stop"
+
+	"github.com/spf13/cobra"
+)
+
+func addPlatformSpecificCommands(root *cobra.Command) {
+	root.AddCommand(backup.NewBackupCmd())
+	root.AddCommand(install.NewInstallCmd())
+	root.AddCommand(reset.NewResetCmd())
+	root.AddCommand(restore.NewRestoreCmd())
+	root.AddCommand(start.NewStartCmd())
+	root.AddCommand(status.NewStatusCmd())
+	root.AddCommand(stop.NewStopCmd())
+}

pkg/cleanup/bridge_other.go → cmd/root_other.go

@@ -1,7 +1,7 @@
 //go:build !linux
 
 /*
-Copyright 2021 k0s authors
+Copyright 2024 k0s authors
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
@@ -16,8 +16,8 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package cleanup
+package cmd
 
-func newBridgeStep() Step {
-	return nil
-}
+import "github.com/spf13/cobra"
+
+func addPlatformSpecificCommands(root *cobra.Command) { /* no-op */ }

cmd/root_test.go

@@ -21,6 +21,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
+	"runtime"
 	"slices"
 	"strings"
 	"testing"
@@ -77,10 +78,12 @@ func TestUnknownSubCommandsAreRejected(t *testing.T) {
 	commandsWithArguments := []string{
 		"controller",
 		"kubeconfig create",
-		"restore",
 		"token invalidate",
 		"worker",
 	}
+	if runtime.GOOS == "linux" {
+		commandsWithArguments = append(commandsWithArguments, "restore")
+	}
 	t.Cleanup(func() {
 		if !t.Failed() {
 			assert.Empty(t, commandsWithArguments, "Some sub-commands are listed unnecessarily")

cmd/start/start.go

@@ -1,3 +1,5 @@
+//go:build linux
+
 /*
 Copyright 2021 k0s authors
 

cmd/status/status.go

@@ -1,3 +1,5 @@
+//go:build unix
+
 /*
 Copyright 2021 k0s authors
 

cmd/stop/stop.go

@@ -1,3 +1,5 @@
+//go:build linux
+
 /*
 Copyright 2021 k0s authors
 

internal/pkg/users/lookup_unix_test.go

@@ -1,3 +1,5 @@
+//go:build unix
+
 /*
 Copyright 2022 k0s authors
 

pkg/cleanup/cleanup.go

@@ -1,3 +1,5 @@
+//go:build linux
+
 /*
 Copyright 2021 k0s authors
 

pkg/cleanup/services.go

@@ -1,3 +1,5 @@
+//go:build linux
+
 /*
 Copyright 2021 k0s authors
 

pkg/cleanup/users.go

@@ -1,3 +1,5 @@
+//go:build unix
+
 /*
 Copyright 2021 k0s authors
 

pkg/install/linux_openrc.go

@@ -1,3 +1,5 @@
+//go:build linux
+
 /*
 Copyright 2022 k0s authors
 

pkg/install/linux_systemd.go

@@ -1,3 +1,5 @@
+//go:build linux
+
 /*
 Copyright 2024 k0s authors
 

pkg/install/linux_sysv.go

@@ -1,3 +1,5 @@
+//go:build linux
+
 /*
 Copyright 2022 k0s authors
 

pkg/install/linux_upstart.go

@@ -1,3 +1,5 @@
+//go:build linux
+
 /*
 Copyright 2022 k0s authors
 

pkg/install/service.go

@@ -1,3 +1,5 @@
+//go:build linux
+
 /*
 Copyright 2020 k0s authors
 

pkg/install/users.go

@@ -65,6 +65,8 @@ func DeleteControllerUsers(systemUsers *v1beta1.SystemUser) error {
 			if err := deleteUser(userName); err != nil {
 				errs = append(errs, err)
 			}
+		} else if !errors.Is(err, users.ErrNotExist) {
+			errs = append(errs, err)
 		}
 	}