Skip to content

Commit

Permalink
justify etcd sync retry duration in comment
Browse files Browse the repository at this point in the history
Signed-off-by: Ethan Mosbaugh <[email protected]>
  • Loading branch information
emosbaugh committed Nov 8, 2024
1 parent d0ccea6 commit 7429cb8
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pkg/component/controller/etcd.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,11 @@ func (e *Etcd) syncEtcdConfig(ctx context.Context, etcdRequest v1beta1.EtcdReque
etcdResponse, err = e.JoinClient.JoinEtcd(ctx, etcdRequest)
return err
},
// When joining multiple nodes in parallel, etcd can lose consensus and will return 500 responses
// Allow for more time to recover (~ 15 minutes)
retry.Attempts(20),
retry.Delay(1*time.Second),
retry.MaxJitter(1*time.Second),
retry.MaxDelay(60*time.Second),
retry.Context(ctx),
retry.LastErrorOnly(true),
retry.OnRetry(func(attempt uint, err error) {
Expand Down

0 comments on commit 7429cb8

Please sign in to comment.