Implement session management to only allow changes made by logged in users #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e CreateAccount function signature
…fix failing tests
…interactions and error handling
…d improve session retrieval logic
… built from the Lobby object for request body
…ted tests for JSON request body
…OwnerAccountId in JSON request body
…nclude OwnerAccountId in request body
|
Hopefully the last big overhaul this project has to go through - this was a LOT of code to change. Good thing we're starting early! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a long time coming, but this feature will add the feature that only users that are logged into their account can change their respective account (or alter the lobbies they made / are given permission to).
This is very necessary for the game server to function properly and will take quite a bit of work.