-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pie-docs): DSW-2222 add toast provider docs #2104
base: main
Are you sure you want to change the base?
Conversation
|
|
{% notification { | ||
type: "information", | ||
message: "The priority queue is managed by the [Toast Provider](/components/toast/toast-provider/code/) in engineering." | ||
} %} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{% notification { | |
type: "information", | |
message: "The priority queue is managed by the [Toast Provider](/components/toast/toast-provider/code/) in engineering." | |
} %} | |
{% notification { | |
type: "information", | |
message: "The priority queue is managed by the [Toast Provider](/components/toast/toast-provider/code/) component that's currently in development." | |
} %} | |
Just my POV, but I think this reads a bit nicer 👍🏼
{% notification { | ||
type: "neutral", | ||
iconName: "link", | ||
message: "See [here](https://github.com/justeattakeaway/pie/blob/main/packages/components/pie-toast/CHANGELOG.md)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message: "See [here](https://github.com/justeattakeaway/pie/blob/main/packages/components/pie-toast/CHANGELOG.md)." | |
message: "See [here](https://github.com/justeattakeaway/pie/blob/main/packages/components/pie-toast-provider/CHANGELOG.md)." |
Note this this URL doesn't currently exist as the component hasn't been published to npm yet, but the changelog.md will get generated in this location once that's been done 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments
Describe your changes (can list changeset entries if preferable)
pie-toast-provider
docsAuthor Checklist (complete before requesting a review)
Reviewer checklists (complete before approving)
Reviewer 1 - @siggerzz
Reviewer 2