Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pie-aperture): DSW-1581 sync form pages across apps #57

Merged
merged 9 commits into from
Feb 2, 2024
Merged

feat(pie-aperture): DSW-1581 sync form pages across apps #57

merged 9 commits into from
Feb 2, 2024

Conversation

jamieomaguire
Copy link
Contributor

  • Added general PIE support to the Nuxt app
  • Update the NextJS and Vanilla JS app form pages to look and behave the same
  • Added form page to the Nuxt app to look and function the same as NextJS and Vanilla Apps

@github-actions github-actions bot temporarily deployed to vanilla-app-pr-57 January 31, 2024 14:35 Inactive
fernandofranca
fernandofranca previously approved these changes Jan 31, 2024
View reviewed changes
@github-actions github-actions bot temporarily deployed to vanilla-app-pr-57 January 31, 2024 15:25 Inactive
@github-actions github-actions bot temporarily deployed to vanilla-app-pr-57 January 31, 2024 16:14 Inactive
fernandofranca
fernandofranca previously approved these changes Feb 1, 2024
View reviewed changes
@github-actions github-actions bot temporarily deployed to vanilla-app-pr-57 February 1, 2024 13:49 Inactive
ashleynolan
ashleynolan previously approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@ashleynolan ashleynolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏

@github-actions github-actions bot temporarily deployed to vanilla-app-pr-57 February 1, 2024 16:41 Inactive
@jamieomaguire
Copy link
Contributor Author

Ben and I have agreed to disable the Nuxt build step and browser tests until we get SSR enabled via Amplify

@jamieomaguire jamieomaguire merged commit 4ed9786 into main Feb 2, 2024
21 checks passed
@jamieomaguire jamieomaguire deleted the DSW-1581-form-pages branch February 2, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleynolan ashleynolan ashleynolan approved these changes

@fernandofranca fernandofranca fernandofranca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamieomaguire @fernandofranca @ashleynolan