Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable Nuxt system tests in CI #220

Merged
merged 1 commit into from
Oct 17, 2024
Merged

enable Nuxt system tests in CI #220

merged 1 commit into from
Oct 17, 2024

Conversation

jamieomaguire
Copy link
Contributor

@jamieomaguire jamieomaguire commented Oct 16, 2024 •
edited
Loading

  • Enables the system tests on CI for the Nuxt app

@jamieomaguire
Copy link
Contributor Author

@xander-marjoram I notice the text area isn't showing text in the visual tests for Next 14. I am unsure if this is a legit regression or a Percy quirk, as the text appears on render just fine in the Browser. My follow up PR will be enabling visual tests in Nuxt. So I am inclines to approve the screenshots in this PR as I will be revisiting them immediately after.

Are you happy with this?

@jamieomaguire jamieomaguire merged commit 82196f5 into main Oct 17, 2024
19 checks passed
@jamieomaguire jamieomaguire deleted the DSW-2157-nuxt-tests branch October 17, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raoufswe raoufswe raoufswe approved these changes

@xander-marjoram xander-marjoram xander-marjoram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamieomaguire @xander-marjoram @raoufswe