Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configs.h flipper zero #445

Closed

Conversation

TheloniusFunkadelic
Copy link

One comment, one uncomment, lines 17 and 21 respectively

One comment, one uncomment, lines 17 and 21 respectively
@aubreyshomo
Copy link
Contributor

@TheloniusFunkadelic: I see this is your first PR, so let me give you some advice.

Now, I don't speak for the man, but it's unlikely this will be merged. (Based on my own expierence.)

The reason is that koko has the build defaults he's decided on, which target a full-fledged marauder hardware platform.

The only effect of this pull request is to change the default target for the project.

Usually, an unsolicited pull request must add features that the project's maintainer(s) believe will benefit the project for everyone.

Unless you discussed with koko or the project changing the build's default target (which, given this is your first PR on github, I doubt), this doesn't actually further the project in any way.

Don't want to be hard on your first PR. My first PR added a line to someone else's project, too, but it was a bug fix.

You probably want something like that -- fix a bug, make a widget -- if you want to get merged.

Generally, your local environment config.h changes won't make it back into the project. All this does is make everyone build for the flipper by default.

Again, not the man, just a passerby, and I do not speak for this project. But I wanted to offer some friendly help in getting that Pull Shark badge.

@TheloniusFunkadelic
Copy link
Author

I don't know what I did here, I wasn't trying to add or change anything, I must have mashed the wrong button or something. Apologies, and thanks for the tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants