Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMEA Passthrough: BUG FIX + Queue Display Feature Add #435

Merged
merged 5 commits into from
Dec 18, 2023

Conversation

aubreyshomo
Copy link
Contributor

BUG FIX: When stopping the NMEA Passthrough via the screen, as opposed to serial, the stopscan function was never called, which led to the queue staying active after exit, promptly filling up available heap and forcing reboot.

FIX: Now call stopscan (via startscan(SCAN_OFF)) upon exiting the GPS menu, such as when leaving NMEA Passthrough.

SAFTEY MECHANISM ADDED: RunScan now checks if the scan is off yet the queue is on and disables it if so.

FEATURES ADDED:

  1. Above bug fix and safety mechanism
  2. Fixed all-on-one-line display of NMEA passthrough, printing each line of output on its own line
  3. Now prints all text, and the final two sentences (GxGGA and GxRMC), and fills all available space on the screen (as defined by configs.h) with other sentences from the queue, using the available real estate fully.
  4. Wrap is accounted for in the line count.
  5. Wrap is now off for GxTXT parsed display.
  6. Wrap is on (by default) for everything but the MINI, where it is off.
  7. Dynamically sizes output for available screen real estate.

TESTED ON: Flipper Dev Board, Marauder v6 with GPS module (and screen)
PARTIALLY TESTED ON: Mini, no GPS module

NOTE: This fixes a bug I couldn't see until I had screen-capable hardware with GPS to test with. (I note I mentioned only headless had been tested in my last PR.) This version should be quite stable, but the display aspects have not been tested on the mini, I'm coding blind.

Kragg Malak added 4 commits December 16, 2023 23:43
…A passthrough, tracking real estate used. Always prints available text buffer and two self-genned messages. Prints whatever else in the queue (from start) there's room for.
@aubreyshomo
Copy link
Contributor Author

Screenshot of new NMEA Passthrough Screen Display:

image

Had it running all night, memory is fine, as long as the queue is either turned off or serviced.

@justcallmekoko justcallmekoko changed the base branch from master to nmea2 December 18, 2023 21:30
@justcallmekoko justcallmekoko merged commit 6ee3a66 into justcallmekoko:nmea2 Dec 18, 2023
schrab pushed a commit to schrab/ESP32S3Marauder that referenced this pull request Jul 3, 2024
NMEA Passthrough: BUG FIX + Queue Display Feature Add
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants