NMEA Passthrough: BUG FIX + Queue Display Feature Add #435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG FIX: When stopping the NMEA Passthrough via the screen, as opposed to serial, the stopscan function was never called, which led to the queue staying active after exit, promptly filling up available heap and forcing reboot.
FIX: Now call stopscan (via startscan(SCAN_OFF)) upon exiting the GPS menu, such as when leaving NMEA Passthrough.
SAFTEY MECHANISM ADDED: RunScan now checks if the scan is off yet the queue is on and disables it if so.
FEATURES ADDED:
TESTED ON: Flipper Dev Board, Marauder v6 with GPS module (and screen)
PARTIALLY TESTED ON: Mini, no GPS module
NOTE: This fixes a bug I couldn't see until I had screen-capable hardware with GPS to test with. (I note I mentioned only headless had been tested in my last PR.) This version should be quite stable, but the display aspects have not been tested on the mini, I'm coding blind.