Add M5 Stamp S3 support #393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpbelo
commented
Nov 18, 2023
| @@ -4562,4 +4562,4 @@ void WiFiScan::main(uint32_t currentTime) | |||
| packets_sent = 0; | |||
| } | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
yeah, I'm not sure what happened here
jpbelo
commented
Nov 18, 2023
| @@ -373,4 +373,4 @@ class WiFiScan | |||
| static void wifiSnifferCallback(void* buf, wifi_promiscuous_pkt_type_t type); | |||
| static void addPacket(wifi_promiscuous_pkt_t *snifferPacket, int len); | |||
| }; | |||
| #endif | |||
| #endif | |||
|
Hi ! Did You manage to M5Stamp full functionality? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stamp s3 works fine with the multi s3 build, but the built in LED is always white full brightness.
This basically duplicates the multi s3 configuration adding the neo pixel on pin 21.
Maybe some configurations are not needed, but I tried to make as little change as needed compared to the multi s3.
Tested on a M5 Stamp S3 mounted on a flipper zero and works fine, and the LED displays the correct colors for the modes.
Still curious why the BT is disabled on the S3, but when I enable it the build breaks.