Skip to content

Commit

Permalink
feat: add support to nodejs v20 (#348)
Browse files Browse the repository at this point in the history
  • Loading branch information
cjnoname authored Dec 12, 2023
1 parent a76ac05 commit 30d9c04
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/on-push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest] # macos-latest is too slow
node-version: [18.x, 16.x, 14.x]
node-version: [20.x, 18.x, 16.x, 14.x]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/on-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
# Setup .npmrc file to publish to npm
- uses: actions/setup-node@v1
with:
node-version: '18.x'
node-version: '20.x'
# Needs to be explicitly specified for auth to work
registry-url: 'https://registry.npmjs.org'
- run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ The permissions can also be added to all lambdas using setting the role to `IamR
```yaml
provider:
name: aws
runtime: nodejs18.x
runtime: nodejs20.x
iamRoleStatements:
- Effect: 'Allow'
Action:
Expand Down
2 changes: 1 addition & 1 deletion src/warmer.js
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ function addWarmUpFunctionToService(service, warmerName, warmerConfig) {
memorySize: warmerConfig.memorySize,
name: warmerConfig.name,
...(warmerConfig.architecture ? { architecture: warmerConfig.architecture } : {}),
runtime: 'nodejs18.x',
runtime: 'nodejs20.x',
package: warmerConfig.package,
timeout: warmerConfig.timeout,
...(Object.keys(warmerConfig.environment).length
Expand Down
2 changes: 1 addition & 1 deletion test/utils/configUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ function getExpectedFunctionConfig(options = {}) {
handler: `.warmup/${warmerName}/index.warmUp`,
memorySize: 128,
name: `warmup-test-dev-warmup-plugin-${warmerName}`,
runtime: 'nodejs18.x',
runtime: 'nodejs20.x',
package: {
individually: true,
patterns: ['!**', path.join('.warmup', warmerName, '**')],
Expand Down

0 comments on commit 30d9c04

Please sign in to comment.