Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: Remove node < 18 from CI matrix #118

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Conversation

broofa
Copy link
Member

@broofa broofa commented Dec 11, 2023

Putting this up so we have something to look at for #115. Cutoff does not have to be at node@16. That's just where we'd draw the line in the world of uuid.

Maybe create a v3 branch / milestone for this and the peerDependency change (if/when that happens), and the mime-score PR (coming soon)?

@broofa
Copy link
Member Author

broofa commented Dec 11, 2023

Should the io.js platforms be removed as well?

@dougwilson
Copy link
Contributor

Should the io.js platforms be removed as well?

Yes, especially them. They give trouble every so often I want them gone 100% in the next major lol

@dougwilson
Copy link
Contributor

Just checking in as this is not forgotten. Will finalize once the Express versions are hammered down so we know this is usable in Express.

@wesleytodd
Copy link
Member

We have moved to drop up to node 18 for express. @broofa I pushed that change, as well as adding node 22 here. Also re-targeting this to a new 3.x branch.

@wesleytodd wesleytodd changed the base branch from master to 3.x August 23, 2024 22:55
@wesleytodd wesleytodd changed the title v3: Remove node < 16 from CI matrix v3: Remove node < 18 from CI matrix Aug 23, 2024
@wesleytodd wesleytodd merged commit b8d40c0 into jshttp:3.x Aug 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants