Add winget action #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayuhito
reviewed
Jul 11, 2023
There was a problem hiding this comment.
It looks good to me in general but I was wondering why you didn't choose the GoReleaser variant of the packager?
The end result would be the same, but I think the GoReleaser variants add much more metadata to the manifest and would be a more cohesive experience.
Its less automated, this action syncs the fork automatically and handles everything |
ayuhito
approved these changes
Oct 15, 2023
|
@jimaek, I think this should now work theoretically and it works locally for me. Just need to run it with all the proper tokens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're already present here https://github.com/microsoft/winget-pkgs/tree/master/manifests/j/jsdelivr/Globalping so I want to add auto updates.
Repo forked and token added.
@ayuhito since you were looking into this can you please check this PR?