Patch Issue #1360

[kirevdokimov]

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Does your submission pass tests? (did not run tests yet)

It works smoothly for a sample case from the issue and for my complex real case

[hrgdavor]

I am not very good at reviewing, but I did run tests locally, and they passed

[z3dev]

@kirevdokimov The changes are straight forward, and probably fix the special case. But I'm wondering if there's another issue with the algorithm, or the union is returning some strange polygons.

im not sure that I'll have time to research further, so I added @platypii to the review.

[kirevdokimov]

@z3dev Retesselation works perfectly fine with this one issue. It is not a specific case. There are cases with union, subtract, and anything else that uses retesselation. The only problem with commenting retesselation out from these functions is that some triangles are left in the air.

I will let you know if I find something else, but this issue is obvious, easy to fix, and does not affect anything else badly.

[z3dev]

The only problem with commenting retesselation out from these functions is that some triangles are left in the air.

I was suspecting something like this. Hopefully, @platypii will have some time to investigate as the simple design is producing a nice test case.

FYI, the fix looks fine.

[platypii]

The fix seems fine, but I haven't yet been able to reproduce the original error on master?
#1360 (comment)

[z3dev]

@kirevdokimov Can you supply a small test case?