Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: x3d defs caching #1338

Merged
merged 3 commits into from
May 23, 2024

Conversation

christopher-krause
Copy link
Contributor

@christopher-krause christopher-krause commented Apr 26, 2024

If we use this parser for multiple files with identical DEF signatures this caching will remove necessary definitions for the x3d.

Now it will be empty for every new parser.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

Note: please do NOT include build files (those generate by the build-xxx commands) with your PR,

Thank you for your help in advance, much appreciated !

If we use this parser for multiple files with identical DEF signatures this caching will remove necessary definitions for the x3d.

Now it will be empty for every new parser.
@z3dev
Copy link
Member

z3dev commented May 23, 2024

@christopher-krause I like this change, but wonder if ALL the x3d* control variables should be moved inside the createX3DParser() function. Have you tried that?

@christopher-krause
Copy link
Contributor Author

@z3dev Not yet, for my purpose it was fine to just move this part.

@christopher-krause
Copy link
Contributor Author

christopher-krause commented May 23, 2024

Now you can take a look, all tests passed in this package. Tests for the project are failing because of some kind of Event issue in @jscad/web.

image

@z3dev
Copy link
Member

z3dev commented May 23, 2024

Now you can take a look, all tests passed in this package. Tests for the project are failing because of some kind of Event issue in @jscad/web.

Hmm... i did a clean install from this branch, and ran all the test suites successfully. All CI builds/tests passed as well.

I think these changes are fine.

Copy link
Member

@z3dev z3dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christopher-krause Thanks for the last set of changes. Looks good!

@z3dev z3dev merged commit 7f44197 into jscad:master May 23, 2024
2 checks passed
@christopher-krause christopher-krause deleted the christopher-krause-patch-1 branch May 24, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants