Update script.js

[lynchbyte]

path for pngs updated

[alcore]

I just realized you didn't include an updated .zip (games/triskatopia/.src/g.zip) including this fix - and I accepted somewhat prematurely. Could you create another PR, with just the .zip, when you have a moment?

[lynchbyte]

Hi, I have added the zip file here; https://github.com/lynchbyte/js13k_Triskatopia/blob/main/archive.zip I hope that's ok. I really didn't want to fork the whole games repository. I'm not very good on git and the thought of that made me very very nervous. Cheers, Shauna From: Michał Chojnacki ***@***.***> Sent: Thursday, 19 September 2024 4:17 AM To: js13kGames/games ***@***.***> Cc: lynchbyte ***@***.***>; Author ***@***.***> Subject: Re: [js13kGames/games] Update script.js (PR #19) I just realized you didn't include an updated .zip (games/triskatopia/.src/g.zip) including this fix - and I accepted somewhat prematurely. Could you create another PR, with just the .zip, when you have a moment? - Reply to this email directly, view it on GitHub<#19 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOWTTOSYAQ527ICFLEMPMILZXG7SJAVCNFSM6AAAAABOMYKHB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJZGEZDGNJZGU>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[alcore]

Alright, thanks. I updated it for you.

That said - there's nothing to really be nervous about with Git. You couldn't possibly break anything accidentally, so it's just a learning experience. At worst, or at best - depending on perspective.

[lynchbyte]

Hi, Me again, I think it is a problem was gulp. It was encoding the pngs. Doh! ***@***.*** I edited script.js on git, PR should be there for your approval. Could you please update the 2 png's files in /media. https://github.com/lynchbyte/js13k_Triskatopia/blob/main/media/1.png https://github.com/lynchbyte/js13k_Triskatopia/blob/main/media/blurPic.png Here's the new zip; https://github.com/lynchbyte/js13k_Triskatopia/blob/main/archive.zip Sorry for being a pain. Hopefully this is the fix. Thanks. From: Michał Chojnacki ***@***.***> Sent: Thursday, 19 September 2024 6:33 AM To: js13kGames/games ***@***.***> Cc: lynchbyte ***@***.***>; Author ***@***.***> Subject: Re: [js13kGames/games] Update script.js (PR #19) Alright, thanks. I updated it for you. That said - there's nothing to really be nervous about with Git. You couldn't possibly break anything accidentally, so it's just a learning experience. At worst, or at best - depending on perspective. - Reply to this email directly, view it on GitHub<#19 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOWTTOVPCFXNOPSYCAZYNG3ZXHPODAVCNFSM6AAAAABOMYKHB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJZGM2TEMZWGA>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[alcore]

Done and updated.

But next year, please, preview and test your game while it is still a draft, on the site, before you submit - at that stage you can edit it freely without anyone else involved, which is quite a lot simpler for everyone.

[alcore]

Sidenote: While your updated images displayed fine on my system, 84e9b2c has trouble displaying them, which signals to me there is probably something still wrong with how you're bundling/building them.

[lynchbyte]

Thank you. And will do for next year. From: Michał Chojnacki ***@***.***> Sent: Thursday, 19 September 2024 1:19 PM To: js13kGames/games ***@***.***> Cc: lynchbyte ***@***.***>; Author ***@***.***> Subject: Re: [js13kGames/games] Update script.js (PR #19) Done and updated. But next year, please, preview and test your game while it is still a draft, on the site, before you submit - at that stage you can edit it freely without anyone else involved, which is quite a lot simpler for everyone. - Reply to this email directly, view it on GitHub<#19 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOWTTOROQI57URSEJML2CJTZXI7BXAVCNFSM6AAAAABOMYKHB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJZHA4TINZUHE>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[lynchbyte]

Yes, agreed, I think there is something not quite right with gulp. I never had to use {encoding: false} before this year. Looks like I will have to learn something new for next year. 😔 Thanks again for all your help. function copyMedia() { return gulp.src('./src/media/*.*', {encoding: false} ) .pipe(gulp.dest('dist/media')) } From: Michał Chojnacki ***@***.***> Sent: Thursday, 19 September 2024 1:31 PM To: js13kGames/games ***@***.***> Cc: lynchbyte ***@***.***>; Author ***@***.***> Subject: Re: [js13kGames/games] Update script.js (PR #19) Sidenote: While your updated images displayed fine on my system, 84e9b2c<84e9b2c> has trouble displaying them, which signals to me there is probably something still wrong with how you're bundling/building them. — Reply to this email directly, view it on GitHub<#19 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOWTTOXSKRDAVIVZCR64AMTZXJANRAVCNFSM6AAAAABOMYKHB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJZHEYDIMZSGE>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[alcore]

gulpjs/gulp#2803 seems strictly related. There are some workarounds and fixes mentioned in that thread that you could try (if you haven't seen/tried them already, that is).