Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test escape apos #52

Closed
wants to merge 1 commit into from
Closed

test escape apos #52

wants to merge 1 commit into from

Conversation

ahorek
Copy link
Contributor

@ahorek ahorek commented Feb 9, 2022

a test for https://bugs.ruby-lang.org/issues/16922

it should pass after tables update from #49 but there's still a problem

TestEConv.testEscapeApos:90 expected:<&amp;[&apos;&amp;]> but was:<&amp;[]>

am I doing something wrong? or is there something else that should be adjusted?

ref #45

@headius
Copy link
Member

headius commented Mar 16, 2022

Hmm not sure what the issue is here.

@ahorek
Copy link
Contributor Author

ahorek commented Mar 16, 2022

' should now be escaped as &apos;
the same way as
& is escaped as &amp;

but the test fails and I didn't find out where the problem is.

@ahorek
Copy link
Contributor Author

ahorek commented Mar 16, 2022

since it's passing on the latest JRuby snapshot that includes this change, there's probably something wrong with the test itself.

#56 will be the ultimate solution for a better coverage

closing

@ahorek ahorek closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants