Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eproject.el: don't barf on non file backed buffers #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

eproject.el: don't barf on non file backed buffers #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions eproject.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,15 +549,16 @@ else through unchanged."
"Turn on eproject for the current buffer, if it is in a project."
(interactive)
(let (bestroot besttype (set-before (mapcar #'car eproject-attributes-alist)))
(loop for type in (eproject--all-types)
do (let ((root (eproject--run-project-selector type)))
(when (and root
(or (not bestroot)
;; longest filename == best match (XXX:
;; need to canonicalize?)
(> (length root) (length bestroot))))
(setq bestroot root)
(setq besttype type))))
(when (buffer-file-name (current-buffer))
(loop for type in (eproject--all-types)
do (let ((root (eproject--run-project-selector type)))
(when (and root
(or (not bestroot)
;; longest filename == best match (XXX:
;; need to canonicalize?)
(> (length root) (length bestroot))))
(setq bestroot root)
(setq besttype type)))))
(when bestroot
(setq eproject-root (file-name-as-directory bestroot))

Expand All @@ -566,7 +567,7 @@ else through unchanged."
(condition-case e
(eproject--init-attributes eproject-root besttype)
(error (display-warning 'warning
(format "There was a problem setting up the eproject attributes for this project: %s" e))))
(format "There was a problem setting up the eproject attributes for this project: %s" e))))

;; with :name and :type set, it's now safe to turn on eproject
(eproject-mode 1)
Expand All @@ -577,8 +578,8 @@ else through unchanged."
(condition-case e
(eproject--setup-local-variables)
(error (display-warning 'warning
(format "Problem initializing project-specific local-variables in %s: %s"
(eproject--buffer-file-name) e))))
(format "Problem initializing project-specific local-variables in %s: %s"
(eproject--buffer-file-name) e))))

;; run the first-buffer hooks if this is the first time we've
;; seen this particular project root.
Expand Down