Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magit support #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Magit support #51

wants to merge 2 commits into from

Conversation

dcrewi
Copy link
Contributor

@dcrewi dcrewi commented Feb 4, 2013

Implementation credit goes to @binarin, but I'm requesting a merge because I find it useful. Admittedly, special-casing magit-status-mode buffers smells a little wrong, but the same thing is done with dired buffers. Ideally, there'd be some macro that provides a generic way to add special case buffers to the tests in eproject--buffer-file-name, but I haven't spent any time on it because this works for me.

@jrockway
Copy link
Owner

jrockway commented Feb 6, 2013

Interesting. I think it's probably better to come up with an extension mechanism around eproject-maybe-turn on, and then put the magit stuff in a separate file that uses that extension mechanism. Then we don't require magit (or confuse the byte compiler with warnings about the magit symbols not existing), and users can easily control the features. And other extensions will be able to do something similar without modifying eproject.el directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants