jquery: switch font to self-hosted Cairo #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
reviewed
Dec 16, 2023
|
@timmywil Can you mention somewhere the origin of the Perhaps also add a license file in the Cairo subdirectory, which would include the copyright attribution statement (assuming the source has one). Afaik the OFL is similar to MIT and CC-BY licenses, in so far that it allows free distribution so long as you attribute the author. Right now, the repo doesn't. |
|
File size comparisons
So, a more significant difference from ttf to woff and a relatively minor difference for woff2, but I'll include it now that I have it. Edit: I went ahead and converted a fontawesome woff2. See above for comparisons. |
mgol
approved these changes
Dec 20, 2023
Krinkle
added a commit
that referenced
this pull request
Jan 4, 2024
Set the amount via line-height to match the previous height exactly, rather than approximating via padding. Ref #451
Krinkle
added a commit
that referenced
this pull request
Jan 4, 2024
No longer loaded from TypeKit as of #451.
Krinkle
added a commit
that referenced
this pull request
Jan 4, 2024
Follows-up #451 * URLs were updated to HTTPS at <https://fortawesome.github.com/Font-Awesome>, but this has been a 404 Not Found for a while. It looks like we currently include version 3.0.2, I've now documented this and updated the source URL to https://fontawesome.com/v3/ for future reference. * Move the (unused) font-awesome.css file to the FontAwesome directory, and move said directory to lib/ for clarity. * Fix incorrect license claim from CC BY 3.0 to MIT License for Font Awesome CSS declarations included in base.css. As per the license header in font-awesome.css, and per <https://fontawesome.com/v3/license/>, font is under OFL, and the CSS code under MIT. Only the doc website was under CC BY, not the software itself. * Similarly move Cairo to lib/ and add its entry to NOTICE.txt. * Preserve a copy of the unmodified normalize.css, along with its LICENSE file and the author attribution in the license's copyright statement that the MIT license requires to be preserved.
Krinkle
added a commit
that referenced
this pull request
Jan 4, 2024
Follows-up #451, to avoid cached CSS that references font families that the current HTML no longer loads, and are thus missing.
Krinkle
added a commit
that referenced
this pull request
Apr 13, 2024
Krinkle
added a commit
that referenced
this pull request
Apr 13, 2024
…choose-gifts, big-message No search results for these. Mainly motivated by removing old references to the now-undefined Klavika font. Ref #451.
Krinkle
added a commit
that referenced
this pull request
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-446