Skip to content

Commit

Permalink
Fix target characteristic tokens being incorrect in Salt Next (#4360)
Browse files Browse the repository at this point in the history
  • Loading branch information
joshwooding authored Oct 30, 2024
1 parent 750f690 commit 2f027e9
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 6 deletions.
5 changes: 5 additions & 0 deletions .changeset/hot-tomatoes-hide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@salt-ds/theme": patch
---

Fixed target characteristic tokens being incorrect in Salt Next.
16 changes: 12 additions & 4 deletions packages/core/stories/file-drop-zone/file-drop-zone.qa.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,30 @@ import {
FileDropZoneTrigger,
} from "@salt-ds/core";
import type { Meta, StoryFn } from "@storybook/react";
import { AllRenderer } from "docs/components";
import { QAContainer } from "docs/components";

export default {
title: "Core/File Drop Zone/File Drop Zone QA",
component: FileDropZone,
} as Meta<typeof FileDropZone>;

export const AllExamplesGrid: StoryFn<typeof FileDropZone> = () => {
export const AllExamplesGrid: StoryFn = () => {
return (
<AllRenderer>
<QAContainer cols={2} itemPadding={4}>
<FileDropZone onDrop={() => console.log("files accepted")}>
<FileDropZoneIcon />
<strong>Drop files here or</strong>
<FileDropZoneTrigger />
</FileDropZone>
</AllRenderer>
<FileDropZone
className="saltFileDropZone-active"
onDrop={() => console.log("files accepted")}
>
<FileDropZoneIcon />
<strong>Drop files here or</strong>
<FileDropZoneTrigger />
</FileDropZone>
</QAContainer>
);
};

Expand Down
4 changes: 2 additions & 2 deletions packages/theme/css/characteristics/target-next.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.salt-theme.salt-theme-next {
--salt-target-background-hover: var(--salt-palette-accent);
--salt-target-borderColor-hover: var(--salt-palette-accent-weakest);
--salt-target-background-hover: var(--salt-palette-accent-weakest);
--salt-target-borderColor-hover: var(--salt-palette-accent);
}

0 comments on commit 2f027e9

Please sign in to comment.