Update minimum wrangler to v3.91.0 and remove defunct experimental json config flags #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• also, specify 3.91.0 as the minimum wrangler version, because that’s the release that made wrangler.json support built-in and not an experimental flag any more • lastly, regenerated worker-configuration.d.ts files using updated wrangler types script (no more -j flag, latest version of wrangler)
commit: |
|
finally 😄 (a gruber reference, if you’re familiar) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrangler v3.91.0 turns on
wrangler.jsonsupport by default and removes theexperimentalJsonConfigoption from thegetPlatformProxyfunction (which causes a type error if we continue to pass it). this is great news, because superflare no longer needs to pass-jto every wrangler command and it removes a foot-gun for superflare consumers, but it also means that the new minimum version of wrangler is v3.91.0. i updated all of the npm run scripts to also no longer use-jand re-ranwrangler typesin the docs app, the remix-cms example, and the remix template.here’s the error in the latest GitHub workflow run from
main: https://github.com/jplhomer/superflare/actions/runs/12377634725and here’s the run from this PR: https://github.com/jplhomer/superflare/actions/runs/12398405247