-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON UI #53
JSON UI #53
Conversation
Add stricter TS modes, removing unused refs Updates some imports path to use shortest mode, so they are not changed by vscode auto imports Fix some minor linting errors Signed-off-by: Adrian Panella <[email protected]>
Signed-off-by: Adrian Panella <[email protected]>
Fix operator not migrated to pipe Signed-off-by: Adrian Panella <[email protected]>
Update dependencies versions Compile to es6 Default component options in schemetics Signed-off-by: Adrian Panella <[email protected]>
Signed-off-by: Adrian Panella <[email protected]>
To enhance performance switch all shell/app components to OnPush Signed-off-by: Adrian Panella <[email protected]>
Removes statics views and prepares to loading views from json definitions using widgets Signed-off-by: Adrian Panella <[email protected]>
Signed-off-by: Adrian Panella <[email protected]>
Adds dependency to reactive-json-form-ng Creates luci specific widgets Change routes to use RoutedWidgetComponent to render json UI
Initial definition of views using json Signed-off-by: Adrian Panella <[email protected]>
Yeah! I'm glad you still working on this, I was beginning to worry the project was dead; I'm hoping to poke a round and learn how to help, but I'm not a frontend guy so I'm not sure really how much I can help with this. I do hope to see what sort of thing I can do in terms of allow use of this along with old LuCI in a sufficiently integrated way to be useful as bridging measure. |
Will this require nodejs on the router? If so how big are the required components? Or are you using node to generate js, html, and css that is served by uhttpd, in production? |
Hi @cshoredaniel, as you see, albait a bit slowly, but LUCI-NG it’s still moving forward, and any help is welcomed. Regarding your comments at #44: |
Hi @jow-, when you have a chance, I’d like to know your view on this PR. |
@ianchi - I love it and really like the fact that it allows moving the heavier logic bits to ubus actions on the remote side. Do you see any reason to not merge it, even if it is wip? |
Signed-off-by: Adrian Panella <[email protected]>
Signed-off-by: Adrian Panella <[email protected]>
Hi @jow- , exactly, my idea is that business logic should almost completely reside in backend (Ubus methods) and the view definitions should only handle some minor transformations and mostly deal with pure presentation logic. I sent this as a PR more as an excuse to trigger some discussion. Anyway, I'll merge it and continue from here. |
This PR continues on the ideas from #45. It is still more in proof of concept state, with much pending work everywhere.
My main aim is to settle on how to write the plugins views purely in json. This is a first proposal to expand upon. I still have to better integrate this with the json schema deffinition of UCI config files.
@jow- any comments & ideas are welcomed. Not much work was done yet on the design & styling, so look with broad mind.
So far all views in this version are completely defined in JSON (you can take a look here.
Here are some screenshots,
Overview
System Log
Processes
UCI integration
This is just an example, and is where more work is still needed