Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new color variable #93

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions doxygen-awesome.css
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ html {
--fragment-linenumber-background: #f4f4f5;
--fragment-linenumber-border: #e3e5e7;
--fragment-lineheight: 20px;
--fragment-desc-background: #f4f4f4;

/* sidebar navigation (treeview) colors */
--side-nav-background: #fbfbfb;
Expand Down Expand Up @@ -239,6 +240,7 @@ html {
--fragment-linenumber-color: #cccccc;
--fragment-linenumber-background: #35393c;
--fragment-linenumber-border: #1f1f1f;
--fragment-desc-background: #2e343e;
}
}

Expand Down Expand Up @@ -300,6 +302,7 @@ html.dark-mode {
--fragment-linenumber-color: #cccccc;
--fragment-linenumber-background: #35393c;
--fragment-linenumber-border: #1f1f1f;
--fragment-desc-background: #2e343e;
}

body {
Expand Down Expand Up @@ -1414,8 +1417,8 @@ div.memdoc, div.memproto, h2.memtitle {
}

div.memdoc {
padding: 0 var(--spacing-medium);
background: var(--page-background-color);
padding: 2px var(--spacing-medium);
NecrCode marked this conversation as resolved.
Show resolved Hide resolved
background: var(--fragment-desc-background);
}

h2.memtitle, div.memitem {
Expand Down Expand Up @@ -1791,7 +1794,7 @@ table.memberdecls .memItemRight {
}

table.memberdecls .mdescLeft, table.memberdecls .mdescRight {
background: none;
background: var(--fragment-desc-background);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a problem with this. It doesn't work well with the current design of the member overview. The block above has rounded corners and creates a small gap, which doesn't look nice IMO:

I'd like the background coloring of the brief description to be an option that can be enabled, but I'm not sure how this could be implemented atm. :/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be solved by removing border-right/left-radius for both .memItem left & right respectively,
also i'm not sure about border color (bottom) should it be left as it is, or removed too and added to mdesc's bottom as shown here:
image

or should it be just like this, no borders at all:
image

what do you think? ( and i truly appreciate the detailed feedback, thanks :) !)

color: var(--page-foreground-color);
padding: var(--spacing-small) 0;
}
Expand Down