Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: error color and number color #927

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

bugfix: error color and number color #927

wants to merge 2 commits into from

Conversation

reatang
Copy link

@reatang reatang commented Mar 9, 2020

No description provided.

josdejong
josdejong reviewed Mar 12, 2020
View reviewed changes
src/js/ace/theme-jsoneditor.js Outdated
@@ -102,7 +102,7 @@ color: #96DC5F
color: darkorange
}
.ace-jsoneditor .ace_constant.ace_numeric {
color: red
color: rgb(0, 0, 205)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all colors are using HEX code, it maybe good for consistency to also enter the color for numbers as HEX (#ee422e)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I borrowed the ace editor the color of the number.

josdejong
josdejong reviewed Mar 12, 2020
View reviewed changes
src/scss/jsoneditor/_variables.scss
@@ -5,7 +5,7 @@ $jse-blue: #3883fa !default;
$jse-content-color: #1a1a1a !default;

$jse-string: #006000 !default;
$jse-number: #ee422e !default;
$jse-number: #6897bb !default;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason that you changed the colors for numbers from red to blue? (I would prefer to keep the red color)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

red just like Error 😂

@josdejong
Copy link
Owner

Thanks for your PR @reatang .

Currently the variable $jse-number is used for coloring numbers as well as coloring error text. It's a good idea to separate this. I think though we should create a new $jse-number variable with the same color code as $jse-number (red), and rename the current $jse-error to $jse-error-background, since that's how it is used right now. Does that make sense?

@reatang
Copy link
Author

reatang commented Mar 14, 2020

jse-error-background sounds like background-color rather than text-color.

@josdejong
Copy link
Owner

jse-error-background sounds like background-color rather than text-color.

That's correct: $jse-number was actually used only at one place for a background color, see _editor.scss. Therefore I think it makes sense to rename it. So:

  1. rename 
    $jse-error: #ee2e2e70 !default;
    to 
    $jse-error-background: #ee2e2e70 !default;
  2. create a new $jse-error: #ee2e2e !default;
  3. Change the usages of $jse-number to $jse-error where applicable.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josdejong josdejong josdejong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reatang @josdejong