Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated elpy-pkg.el #2054

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Remove outdated elpy-pkg.el #2054

merged 1 commit into from
Dec 26, 2024

Conversation

tarsius
Copy link
Contributor

@tarsius tarsius commented Dec 26, 2024

PR Summary

The information in <name>-pkg.el did not agree with the information in <name>.el. This pull-requests addresses that be removing the outdated <name>-pkg.el.

While the end-user package manager package.el expects a file <name>-pkg.el, this should only be generate by the package archive (such as GNU ELPA and MELPA), instead of being tracked in the upstream repository.

The tools used maintain the various *ELPA, do not use <name>-pkg.el as a data source, they only generate it it.

  • elpa-admin.el, the tool used for GNU ELPA and NonGNU ELPA, does not use <name>-pkg.el as a data source and it never has.

  • package-build.el, the tool used for Melpa, prefers <name>.el but currently falls back to get information missing from there from <name>-pkg.el instead. I am goint to change that; soon <name>-pkg.el will be ignored as a data source by this tool too.

PR checklist

  • Commits respect our guidelines
  • Tests are passing properly (see here on how to run Elpy's tests)

@gopar gopar merged commit 61540e7 into jorgenschaefer:master Dec 26, 2024
0 of 35 checks passed
@tarsius tarsius deleted the expkg branch December 26, 2024 15:31
@tarsius
Copy link
Contributor Author

tarsius commented Dec 26, 2024

You won the "first merge of this series" price. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants