[5.3] Updating wamania/php-stemmer to 4.0.0 #44657
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial Pull Request for Issue #44504. (DO NOT CLOSE ORIGINAL ISSUE)
Summary of Changes
wamania/php-stemmer depended on voku/portable-utf8 which seems to have been abandoned and also is a gigantic library. Coincidentally, our joomla/string package has all necessary features for the stemmer, so wamania accepted a PR to switch to our library instead. This PR updates our dependency to version 4.0. Since we unfortunately still have the hard requirement for voku/portable-utf8 in our composer.json, this doesn't change anything in codesize, but it does help with the notices being thrown in PHP 8.4.
Testing Instructions
Codereview.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed