[6.0] Removing CMSObject from most of the codebase #44655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laoneo
reviewed
Dec 22, 2024
| * | ||
| * @return array An array with the prefix, suffix and value of the download key | ||
| * | ||
| * @since 4.0.0 | ||
| */ | ||
| public static function getDownloadKey(CMSObject $extension): array | ||
| public static function getDownloadKey($extension): array |
There was a problem hiding this comment.
I would change the typehint to stdClass and not remove it.
Hackwar
added
the
b/c break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR removes CMSObject from a lot of cases in our codebase. The last parts where this is left is the media manager, a few classes and com_finder. For com_finder there is another PR (#43795).
Testing Instructions
Codereview?
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed