Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Apply mail cloaking in finder results #44641

Open
wants to merge 5 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

SniperSister
Copy link
Contributor

Pull Request for Issue #43749

Summary of Changes

Mail addresses in results in com_finder are currently uncloaked, as they are not passed through the OnContentPrepare event.

This PR adds an event handler for the finder results to the cloaking plugin and ensures that the content plugin group is loaded by com_finder.

Testing Instructions

  • Create an article with a searchword, following a a mail address
  • Search for the word in com_finder
  • Inspect the result using your browser dev tools

Actual result BEFORE applying this Pull Request

Mail address in uncloaked.

Expected result AFTER applying this Pull Request

Mail address is cloaked.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [ x] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [x ] No documentation changes for manual.joomla.org needed

@SniperSister SniperSister changed the title Apply mail cloaking in finder results [5.3] Apply mail cloaking in finder results Dec 19, 2024
@brianteeman
Copy link
Contributor

Is it a good idea to import ALL content plugins. Shouldn't it just be the mailcloak plugin

@SniperSister
Copy link
Contributor Author

Fair comment. Updated as suggested.

@ChristineWk
Copy link

After this: Inspect the result using your browser dev tools I got this result:
pr44641

@ChristineWk
Copy link

I have tested this item ✅ successfully on 1c40e08


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44641.

@fgsw
Copy link

fgsw commented Dec 20, 2024

I have tested this item ✅ successfully on 1c40e08

Test by using Prebuilt package.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44641.

@alikon
Copy link
Contributor

alikon commented Dec 20, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44641.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 20, 2024
@SniperSister
Copy link
Contributor Author

The last commit includes more plugins and is irrelevant for the test results, It would suggest to restore the 2 successful tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants