-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] Apply mail cloaking in finder results #44641
Open
SniperSister
wants to merge
5
commits into
joomla:5.3-dev
Choose a base branch
from
SniperSister:public-finder-cloaking
base: 5.3-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SniperSister
changed the title
Apply mail cloaking in finder results
[5.3] Apply mail cloaking in finder results
Dec 19, 2024
Is it a good idea to import ALL content plugins. Shouldn't it just be the mailcloak plugin |
Fair comment. Updated as suggested. |
I have tested this item ✅ successfully on 1c40e08 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44641. |
I have tested this item ✅ successfully on 1c40e08 Test by using Prebuilt package. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44641. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44641. |
Fedik
reviewed
Dec 20, 2024
The last commit includes more plugins and is irrelevant for the test results, It would suggest to restore the 2 successful tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #43749
Summary of Changes
Mail addresses in results in com_finder are currently uncloaked, as they are not passed through the OnContentPrepare event.
This PR adds an event handler for the finder results to the cloaking plugin and ensures that the content plugin group is loaded by com_finder.
Testing Instructions
Actual result BEFORE applying this Pull Request
Mail address in uncloaked.
Expected result AFTER applying this Pull Request
Mail address is cloaked.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
[ x] No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
[x ] No documentation changes for manual.joomla.org needed