Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3][com_actionlogs] exclude self from mail notification #44640

Open
wants to merge 11 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Dec 19, 2024

Pull Request for Issue #44465 .

Summary of Changes

added a radio button to Exclude self action to be notificated by mail to yourself (default is no)

Testing Instructions

set Email Notifications under "User Actions Log Options" of a Super User account to "Yes".
choose some events to email

Actual result BEFORE applying this Pull Request

the events are notifiyed via email to yourself too even you do the event

Expected result AFTER applying this Pull Request

you can exclude yourself to be notifiyed by email when you do an event

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.3-dev labels Dec 19, 2024
@alikon alikon marked this pull request as ready for review December 19, 2024 18:10
@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 5410245


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44640.

@dautrich
Copy link

dautrich commented Dec 21, 2024

I have tested this item 🔴 unsuccessfully on 5410245

The checkbox does work for the super user:

  • with the checkbox set, the super users actions didn't trigger an email.
  • with the checkbox not set, the super user's actions triggered an email.

I also created a user in user group "Administrator". The actions of that user didn't trigger an email if the checkbox was set. These actions could be seen in the User Actions Log.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44640.

@Kostelano
Copy link
Contributor

Yes, there are problems, I rushed and did not check as deeply as I should have. I apologize.

The first thing that definitely does not work is that once the superuser has enabled the option, he no longer receives emails about the actions of any users, not just his own.

@alikon
Copy link
Contributor Author

alikon commented Dec 22, 2024

@Kostelano @dautrich thanks for reporting
could you give another round of test ? should be fixed now

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 7598ad9

Option disabled
As an admin, I receive all messages about actions by mail + actions of other users

Option enabled
As an admin, I receive by mail all messages about the actions of only other users

Option disabled + new user added as second superadmin
As an admin, I receive all user actions by mail again

Option enabled + new user added as second superadmin
As an admin, I only receive actions of other users by email

etc. I ran through all possible other options/combinations. No deviations were noticed. I am sending a successful test


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44640.

@dautrich
Copy link

I have tested this item ✅ successfully on 7598ad9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44640.

@dautrich
Copy link

I can confirm @Kostelano's results. Unlike him, I didn't use two Super User accounts, but a Super User and an account with access level Administrator. But I also tested the four cases like he did.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44640.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants