-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3][com_actionlogs] exclude self from mail notification #44640
base: 5.3-dev
Are you sure you want to change the base?
[5.3][com_actionlogs] exclude self from mail notification #44640
Conversation
Co-authored-by: Richard Fath <[email protected]>
…com/alikon/joomla-cms into exclude-self-from-mail.notification
I have tested this item ✅ successfully on 5410245 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44640. |
I have tested this item 🔴 unsuccessfully on 5410245
I also created a user in user group "Administrator". The actions of that user didn't trigger an email if the checkbox was set. These actions could be seen in the User Actions Log. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44640. |
Yes, there are problems, I rushed and did not check as deeply as I should have. I apologize. The first thing that definitely does not work is that once the superuser has enabled the option, he no longer receives emails about the actions of any users, not just his own. |
@Kostelano @dautrich thanks for reporting |
I have tested this item ✅ successfully on 7598ad9 Option enabled Option disabled + new user added as second superadmin Option enabled + new user added as second superadmin etc. I ran through all possible other options/combinations. No deviations were noticed. I am sending a successful test This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44640. |
I have tested this item ✅ successfully on 7598ad9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44640. |
I can confirm @Kostelano's results. Unlike him, I didn't use two Super User accounts, but a Super User and an account with access level Administrator. But I also tested the four cases like he did. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44640. |
Pull Request for Issue #44465 .
Summary of Changes
added a radio button to Exclude self action to be notificated by mail to yourself (default is no)
Testing Instructions
set Email Notifications under "User Actions Log Options" of a Super User account to "Yes".
choose some events to email
Actual result BEFORE applying this Pull Request
the events are notifiyed via email to yourself too even you do the event
Expected result AFTER applying this Pull Request
you can exclude yourself to be notifiyed by email when you do an event
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed