Add proper error handling for public folder cli installation (#42168)

Co-authored-by: Quy <[email protected]>
joomla · Oct 20, 2023 · 4c799de · 4c799de
1 parent ddbce21
commit 4c799de
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/installation/src/Console/InstallCommand.php b/installation/src/Console/InstallCommand.php
@@ -175,6 +175,8 @@ protected function doExecute(InputInterface $input, OutputInterface $output): in
             $cleanupModel = $app->getMVCFactory()->createModel('Cleanup', 'Installation');
 
             if (!$cleanupModel->deleteInstallationFolder()) {
+                $this->ioStyle->error('Unable to delete installation folder!');
+
                 return Command::FAILURE;
             }
 
@@ -184,7 +186,11 @@ protected function doExecute(InputInterface $input, OutputInterface $output): in
         if (!empty($cfg['public_folder'])) {
             $this->ioStyle->write('Creating the public folder...');
 
-            if (!(new PublicFolderGeneratorHelper())->createPublicFolder($cfg['public_folder'])) {
+            try {
+                (new PublicFolderGeneratorHelper())->createPublicFolder($cfg['public_folder']);
+            } catch (\Exception $e) {
+                $this->ioStyle->error($e->getMessage());
+
                 return Command::FAILURE;
             }