Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unicode constant in form rule #351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Dec 23, 2024

User description

joomla/joomla-cms#44662


PR Type

Documentation


Description

  • Added documentation entry in the migration guide regarding the removal of JCOMPAT_UNICODE_PROPERTIES constant from the FormRule class
  • Provided information about the affected file path: libraries/src/Form/FormRule.php
  • Added guidance for extension developers to copy the constant code if still needed

Changes walkthrough 📝

Relevant files
Documentation
removed-backward-incompatibility.md
Document removal of FormRule unicode constant                       

migrations/54-60/removed-backward-incompatibility.md

  • Added documentation about the removal of JCOMPAT_UNICODE_PROPERTIES
    constant from FormRule class
  • Provided guidance for extensions still using the deprecated constant
  • +6/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant