Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the empty indexer files #349

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove the empty indexer files #349

wants to merge 1 commit into from

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Dec 20, 2024

User description

joomla/joomla-cms#44646


PR Type

Documentation


Description

  • Documented the removal of non-namespaced indexer files from administrator/components/com_finder/helpers/indexer
  • Added migration guide explaining how to update code from legacy include statements to using namespaced classes
  • Provided clear code examples showing the transition from FinderIndexerHelper to Joomla\Component\Finder\Administrator\Helper\FinderHelper
  • Clarified that the removed files were empty as class aliases already existed

Changes walkthrough 📝

Relevant files
Documentation
removed-backward-incompatibility.md
Documentation for removal of legacy indexer files               

migrations/54-60/removed-backward-incompatibility.md

  • Added documentation about removal of non-namespaced indexer files
  • Provided code examples showing migration from old to new namespaced
    class usage
  • Explained that empty legacy files were removed as class aliases
    already exist
  • +14/-0   

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Documentation Clarity
    The migration guide should explicitly mention that this is a breaking change for extensions that rely on file includes. Consider adding a note about potential impact on third-party extensions.

    Copy link
    Contributor

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant