Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the client id in the model cleanCache function #347

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Dec 19, 2024

User description

For joomla/joomla-cms#44637.


PR Type

Documentation


Description

  • Added documentation for backward compatibility breaking change regarding the removal of clientId attribute from form models' cleanCache function
  • Provided migration instructions for developers who extend these models and override the cleanCache function
  • Updated the backward incompatibility documentation with reference to PR #44637

Changes walkthrough 📝

Relevant files
Documentation
removed-backward-incompatibility.md
Document removal of clientId from cleanCache function       

migrations/54-60/removed-backward-incompatibility.md

  • Added documentation about removal of clientId attribute from form
    models' cleanCache function
  • Included reference to PR #44637 and migration instructions
  • +5/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Documentation Clarity
    The migration instruction could be more specific about which form models are affected by this change. Consider listing the specific model classes where developers need to remove the clientId parameter.

    Copy link
    Contributor

    Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here.

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant