-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tag.md #287
base: main
Are you sure you want to change the base?
Update tag.md #287
Conversation
- added note on default to mode attribute - added remote-search to attribute list (required for nested to work correctly owing to joomla-cms bug #43803) - added note to ajax mode search min chars - added note to nested mode on joomla-cms bug #43705 destroying the hierarchical display
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
- **id** (optional) is the id to add to the field. Note if none is set this will be the name of the field. | ||
- **class** (optional) is the class to add to the field. | ||
- **published** (optional) determines if non published tags should be allowed. | ||
- **language** (optional) is language to filter the existing tags by. | ||
- **multiple** (optional) is the ability to add more than 1 tag to the form field. | ||
- **custom** (optional) if the ajax mode is chosen setting this to "deny" will prevent users from adding in new tags. | ||
- **remote-seach** (optional) Enables Ajax search - if using mode="nested" you need to set this to "false" or you will only get a partial option list and a broken hierarchy. (*remote-serach="true" (default) only lists a amximum of 30 tags until you search, and orders the list by most used tags first which destroys the heirarchy display. See* [*issue #43803*](https://github.com/joomla/joomla-cms/issues/43803#issuecomment-2234376819)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Correct a typo in the attribute name to ensure proper functionality [Possible issue, importance: 10]
- **remote-seach** (optional) Enables Ajax search - if using mode="nested" you need to set this to "false" or you will only get a partial option list and a broken hierarchy. (*remote-serach="true" (default) only lists a amximum of 30 tags until you search, and orders the list by most used tags first which destroys the heirarchy display. See* [*issue #43803*](https://github.com/joomla/joomla-cms/issues/43803#issuecomment-2234376819)) | |
**remote-search** (optional) Enables Ajax search - if using mode="nested" you need to set this to "false" or you will only get a partial option list and a broken hierarchy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't merge this change, it's only here for demonstrating an issue for codiumai
Co-authored-by: codiumai-pr-agent-pro[bot] <151058649+codiumai-pr-agent-pro[bot]@users.noreply.github.com>
Correct spelling typo in "Quicktask link" sub -head Changed Quicktask link section text to refer to title which appears as a mouseover the icon, and to state that the language string needs to be in the .sys.ini lanuage file Added new sub-section Quicktask Icon with explanation and example. Added fontawesome icon example to the Example section NB there is also a <quicktask-permission> tag but I can find no information how to use it.
|
||
**Nested mode** | ||
|
||
- The tag dropdown list displays a hierarchical list of tags (shown in a similar way to how categories are shown) | ||
- You cannot create new tags on the fly | ||
- This list is sorted by heirarchy order (ordering in the com_tags tag list view) rather than alphabetically by path name | ||
- **NB** *Currently (J5.1.2 and earlier) selected tags are removed from the list which breaks the hierarchy display* (*see* [*issue #43705*](https://github.com/joomla/joomla-cms/issues/43803]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really happy referencing issues in the manual, this would get an maintenance nightmare and could fill the manual with 1000 of referenced issues and pull requests which often is irrelevant and need to be removed if a pr exists or worse keep in the manual if it never get fixed or if it's an expected behavior.
It's a different story in the changelog/migration section which automatically gets obsolete with new versions at some point in time.
User description
The bug notes (in italics) will need removing as the bugs are fixed
PR Type
Documentation
Description
mode
attribute in thetag
form field.remote-search
attribute, including its necessity for nested mode and a link to issue #43803.Changes walkthrough 📝
tag.md
Update `tag.md` with additional attributes and bug notes
docs/general-concepts/forms-fields/standard-fields/tag.md
mode
attribute.remote-search
attribute with explanation and link to issue#43803.