Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User action logger #209

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

User action logger #209

wants to merge 6 commits into from

Conversation

gstark0
Copy link
Contributor

@gstark0 gstark0 commented Jan 9, 2018

As in #189 :)
screen shot 2018-01-09 at 22 16 25

@ftyers

@jonorthwash
Copy link
Owner

jonorthwash commented Jan 9, 2018

Note that 2,4 should be a dobj relationship, not nsubj.

@gstark0
Copy link
Contributor Author

gstark0 commented Jan 10, 2018

@jonorthwash Yes, i need to learn a bit about annotating this :)

@ftyers
Copy link
Collaborator

ftyers commented Jan 10, 2018

<grzegorzs_> spectre: could you take a look at this? https://github.com/jonorthwash/ud-annotatrix/pull/209
<begiak> [ [WIP] User action logger by gstark0 · Pull Request #209 · jonorthwash/ud-annotatrix · GitHub ]
<spectre> grzegorzs_, looks good
<spectre> but it should be optional
<spectre> e.g. perhaps a button next to the three buttons at the bottom right
<spectre> and i think (to avoid horribly long stuff
<spectre> you could save just the first annotation time
<spectre> and then deltas
<grzegorzs_> spectre: Okay, I will add this, also, id like to improve this, what else would you like it to log?
<spectre> so if the first time is 1045
<spectre> and then the next time is 1048
<spectre> and then the next time is 1100
<spectre> then it would be:
<spectre> AnnoTime=1045,3,52

And then the time at each point would be the sum of the times before.

@gstark0
Copy link
Contributor Author

gstark0 commented Jan 10, 2018

@ftyers
How about now? Deltas added, button to enable/disable logger also added (toolbar at the top, the icon changes if its enabled or disabled).
@jonorthwash There is no dobj on the list :(
screen shot 2018-01-10 at 14 05 33

@gstark0
Copy link
Contributor Author

gstark0 commented Jan 10, 2018

I moved the button to the bottom. Icon will be probably changed.

screen shot 2018-01-10 at 17 16 03

@gstark0
Copy link
Contributor Author

gstark0 commented Jan 10, 2018

Icon changed :)

Disabled:
screen shot 2018-01-10 at 17 42 09
Enabled:
screen shot 2018-01-10 at 17 42 14

@gstark0 gstark0 changed the title [WIP] User action logger User action logger Jan 11, 2018
@ftyers
Copy link
Collaborator

ftyers commented Jan 12, 2018

@gstark0 can you make it so that the enabled icon is the disabled icon but highlighted ? e.g. disabled = blue camera on white background, enabled = white camera on blue background.

@gstark0
Copy link
Contributor Author

gstark0 commented Jan 12, 2018

@ftyers Fixed.

@ftyers
Copy link
Collaborator

ftyers commented Jan 12, 2018

@gstark0 cool, leave a screenshot and I'll check it out.

@gstark0
Copy link
Contributor Author

gstark0 commented Jan 12, 2018

@ftyers
screen shot 2018-01-12 at 17 10 47
screen shot 2018-01-12 at 17 10 43

@ftyers
Copy link
Collaborator

ftyers commented Jan 13, 2018

Cool, the only thing I wonder now is if we could instead of starting the unixtime from 0 for each token
have a comment in the comment block at the beginning with the first time that the sentence was editted and then do offsets from there. But I'm not sure of the pros/cons of that.

@jonorthwash
Copy link
Owner

Is there a tooltip for the icon explaining what it does?

@gstark0
Copy link
Contributor Author

gstark0 commented Jan 15, 2018

@jonorthwash sure. But dont Merge it yet, I want to add the features ftyres mentioned.

@gstark0
Copy link
Contributor Author

gstark0 commented Jan 18, 2018

@ftyers Updated.
screen shot 2018-01-18 at 19 35 06
screen shot 2018-01-18 at 19 35 24
screen shot 2018-01-18 at 19 35 37

@gstark0
Copy link
Contributor Author

gstark0 commented Jan 19, 2018

@ftyers Here is how it looks like when misc column is not empty:
screen shot 2018-01-19 at 15 44 45
screen shot 2018-01-19 at 15 44 54
screen shot 2018-01-19 at 15 45 06
screen shot 2018-01-19 at 15 45 24

@jonorthwash jonorthwash force-pushed the master branch 7 times, most recently from c8c83a7 to b6180dc Compare June 11, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants