Move CI to Xcode 15.3 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First pass at Swift concurrency checking. Problem is that Core Data itself is not updated. Remaining problems currently easily unworkaroundable: * Container metadata [String:Any] — need a Sendable version of this * NSPC::loadPersistentStores() — the callback semantics need formalizing in the new world In addition having to @preconcurrency import CoreData in a bunch of places.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 95.55% 93.40% -2.15%
==========================================
Files 13 28 +15
Lines 1192 2760 +1568
==========================================
+ Hits 1139 2578 +1439
- Misses 53 182 +129 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And first pass at Swift concurrency checking.