Skip to content

Commit

Permalink
fix: Fix macOS arm64 crashes (shaka-project#54)
Browse files Browse the repository at this point in the history
Enabling position independent code (PIC) resolves a crash in macOS arm64 builds.  The idea to try this came from a relocation-related build failure on another machine, followed by me stubmling across a note that iOS requires PIC.

Closes shaka-project#51
  • Loading branch information
joeyparrish authored Nov 10, 2024
1 parent a27e0a0 commit 3fd76db
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions build-scripts/90-ffmpeg.sh
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ elif [[ "$RUNNER_OS" == "macOS" ]]; then
# else to resolve this, and from my searches, it appears that others are not
# having this problem with ffmpeg. This is still a problem with n7.1
PLATFORM_CONFIGURE_FLAGS="$PLATFORM_CONFIGURE_FLAGS --disable-x86asm --disable-inline-asm"

# Enable position independent code (PIC). This resolved a crash on arm64.
PLATFORM_CONFIGURE_FLAGS="$PLATFORM_CONFIGURE_FLAGS --enable-pic"
elif [[ "$RUNNER_OS" == "Windows" ]]; then
# /usr/local/incude and /usr/local/lib are not in mingw's include
# and linker paths by default, so add them.
Expand Down

0 comments on commit 3fd76db

Please sign in to comment.