Added ability to make default time on the watch be PC clock's during …

[voloved]

When running make, you can include DATE=, which will set the default time on the watch to the PC's.
Below are example outputs of the setting.

user@DESKTOP-UCQND0L:~/sensorWatch/Sensor-Watch/movement/make$ make COLOR=RED
git submodule update --init
size:
   text    data     bss     dec     hex filename
 109436    2676   11604  123716   1e344 build/watch.elf
 109436    2676   11604  123716   1e344 (TOTALS)
 
user@DESKTOP-UCQND0L:~/sensorWatch/Sensor-Watch/movement/make$ make COLOR=RED DATE=YEAR
Default year and timezone are set to 2024 EDT
git submodule update --init
size:
   text    data     bss     dec     hex filename
 109436    2676   11604  123716   1e344 build/watch.elf
 109436    2676   11604  123716   1e344 (TOTALS)
 
user@DESKTOP-UCQND0L:~/sensorWatch/Sensor-Watch/movement/make$ make COLOR=RED DATE=DAY
Default date set to Jul 07 2024 EDT
git submodule update --init
size:
   text    data     bss     dec     hex filename
 109436    2676   11604  123716   1e344 build/watch.elf
 109436    2676   11604  123716   1e344 (TOTALS)
 
user@DESKTOP-UCQND0L:~/sensorWatch/Sensor-Watch/movement/make$ make COLOR=RED DATE=MIN
Default time set to 12:45 on Jul 07 2024 EDT
git submodule update --init
size:
   text    data     bss     dec     hex filename
 109436    2676   11604  123716   1e344 build/watch.elf
 109436    2676   11604  123716   1e344 (TOTALS)
 
user@DESKTOP-UCQND0L:~/sensorWatch/Sensor-Watch/movement/make$ make COLOR=RED DATE=foo
../../make.mk:276: *** DATE must be YEAR, DAY, or MIN if used..  Stop.

Context in Discord

[matheusmoreira]

I feel like there should be a way to set this statically, without looping over the time zones at runtime. We need to figure out the index of the timezone. Perhaps the makefile can figure out or call a script that figures it out, then it can pass the index via preprocessor definition.

[matheusmoreira]

I would suggest defining static functions that return the initial time components and putting the #ifdefs in them. This avoids adding complexity to the initialization function. They'll just return constants so the compiler is likely to eliminate the functions when they are compiled.

static uint16_t get_initial_year(void)
{
#ifdef MAKEFILE_CURR_YEAR
    return MAKEFILE_CURR_YEAR;
#else
    return 3;
#endif
}

// ...

date_time.unit.year = get_initial_year();

[matheusmoreira]

I suggest not mentioning MAKEFILE in these variables. Users might add them to a header file and include it instead. The makefile therefore wouldn't be the only source of these values. See also PR #295 for example.

I suggest INITIAL_TIMEZONE, INITIAL_YEAR, and so on.

[matheusmoreira]

This adds a direct dependency on GNU coreutils for building the firmware. I consider that to be perfectly OK but then again I've been running Linux for over a decade. I have no idea how this impacts Windows users. Maintainers might want to double check this.

[mcguirepr89]

Not sure if this is worth much, but it's been helpful for me. For Linux users who only add these 4 lines and don't change any other files, sed can do all the work except setting the timezone offset (though it's kind of hacky).

From movement/make:

sed -Ei "s/(unit.year = ).*(;)/\1$(( $(date +%-g) - 20 ))\2/;s/(unit.month = ).*(;)/\1$(date +%-m)\2/;s/(unit.day = ).*(;)/\1$(date +%-d)\2/;s/(unit.hour = ).*(;)/\1$(date +%-H)\2/;s/(unit.minute = ).*(;)/\1$(( $(date +%-M) + 1))\2/" ../../watch-library/hardware/main.c && make COLOR=YOURCOLOR && make install COLOR=YOURCOLOR

I know it's not pretty, but it is handy. (It also adds 1 minute to the time to allow you to put the watch back together.)

[matheusmoreira]

Looks great!!

[matheusmoreira]

This is a good PR but since movement 2.0 will bring about a new build system it seems pointless to merge this in right now. Let's wait and revisit this after the refactoring is done!