Expose character mapping internals and add invert #346
Conversation
There was a problem hiding this comment.
Exposing the character segmap data is an excellent improvement which makes for more readable implementation!
I think the code for inverting the display belongs on a separate pull request so it can be evaluated independently from the aforementioned change. Notably, none of the watch faces updated by the commit make use of this new display inversion functionality.
|
Heh, indeed it would make sense to split the invert. But the whole reason this code exists was to support the 'invert' (see linked PR), and I really wanted to sneak it in so I have less to update. I feel like the chances of getting the invert merged on its own are low! It someone indicates they'd actually accept this if I removed the invert I'll do it. But I'd love to have the whole thing merged :) |
wryun
force-pushed
the
expose-character-mapping-internals-and-add-invert
branch
2 times, most recently
from
e9d9800 to
ea4d5d0
Compare
Allowing the faces to access the internal segment mapping code makes it easier to have custom characters and have fancy effects.
Allowing the faces to access the internal segment mapping code makes it easier to have custom characters and have fancy effects.
This is the refactoring which was originally done for #102 with a few tweaks to keep it up to date.
This also adds the ability to invert the display (bonus) and reduces some minor code duplication (for the _lp display function).