Skip to content
This repository has been archived by the owner on May 8, 2022. It is now read-only.

update gem for rails 6.1 + ruby 3.0.2 #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

robmathews
Copy link

Mostly ruby 2.7+, I guess, since it was just keyword parameters.

@Narnach
Copy link

Narnach commented Aug 31, 2021

It looks like it does what it is supposed to 🎉

I was unable to (quickly) get the tests running locally (likely due to rails 3 and ancient rake not playing nice with a modern system), so could not validate it that way.

I've integrated this into my own fork to test it in practice against a large real codebase, and deprecation warnings disappeared in the test suite, without introducing new errors. Consider this anecdotal evidence for working on rails 6.1 + ruby 2.7. 👍

@janxious
Copy link

janxious commented Jan 7, 2022

thanks for this 👍

@calebwoods
Copy link

Any chance this could get integrated for a RubyGems release?

@mathieujobin
Copy link

I tried to get the tests to run on github actions, but test-unit is ancient, stubbing is done through mocha and I'm getting several weird errors.

https://github.com/payrollhero/dynamic_form/runs/6333790595
https://test-unit.github.io
https://mocha.jamesmead.org/

anyone know what provides convert_to_model ?

@janxious
Copy link

janxious commented May 7, 2022

anyone know what provides convert_to_model ?

part of ActionView, it used to be in a different place so maybe the included module needs to change or something https://apidock.com/rails/ActionView/ModelNaming/convert_to_model

@mathieujobin
Copy link

Note that I have tried switching my app to use this branch, and I am getting several tests failures. I have yet to investigate what they are.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants