fix: handle case where karma is run in new window #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of an iframe if client.useIframe is set to false the test context is in a new window so we need to use the `opener` to get the original location to grab the browser ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
client.useIframeis set to false the test context is in a new window instead of an iframe. So we need to use theopenerto get the original location to grab the browser ID, rather thanparent.What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
Currently karma allows setting the
client.useIframeconfiguration to false to run tests in a new window. Butkarma-paralleldoesn't handle that case and skips sharding.What is the current behavior? (You can also link to an open issue here)
The current behavior is to try to fetch the browser ID from the parent window assuming current context is an iframe. But the context is actually a new window.
What is the new behavior (if this is a feature change)?
The initializer will now honor the
client.useIframeconfiguration and not skip sharding if it is set to false.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
N/A