Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store-ref-data.sh: Ensure run from testing directory and make more robust
shopt -s nullglob
to make sure that../examples/*
expands to nothing rather than to itself when there are no matches.
Otherwise, running in the LIFE directory leads to
rm -rf *
!give a helpful error message if it isn't.
are spaces or shell metacharacters in variables. It would also have
stopped the "*" being interpreted as a wildcard.
have printf format characters (e.g. %) in them, it would lead to unintended
results.
Mostly, this is just defensive bash programming. Issues like these can
be found easily using
shellcheck
, either on the command line, or athttps://www.shellcheck.net. Integrating a shell checker in your editor
is also helpful (I use flycheck for emacs).
Or just use python :)
run-tests.sh: Add check for correct directory and make more robust
Now passes shellcheck.
--
I have tested that storing the reference data and running the tests works after this change.