feat: add new values for session & user profile #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzysztof-cislo
approved these changes
Dec 20, 2024
|
Hi @jimmykane ! It's us again. 🙂 Can you merge the PR and release new version, please? Thanks! |
|
Will do asap. Put a reminder for tomorrow as now I am on the road again is that ok? |
Hi @jimmykane I know that it's holiday time, but if you can find some time to create a release we will be very grateful. |
Hi again @jimmykane ! Any chance to merge this ASAP? 🙏 |
|
Done. Thank you and sorry for the delay.
…On Thu, Jan 2, 2025, 9:56 AM Krzysztof Cisło ***@***.***> wrote:
Will do asap. Put a reminder for tomorrow as now I am on the road again is
that ok?
Hi @jimmykane <https://github.com/jimmykane> I know that it's holiday
time, but if you can find some time to create a release we will be very
grateful.
Hi again @jimmykane <https://github.com/jimmykane> ! Any chance to merge
this ASAP? 🙏
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJVX4YEHDYC77WYQEYLMHL2ITWMVAVCNFSM6AAAAABT4S5J7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRXGM4TGMJTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thank you! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on fitsdk/Profile
Extracting two new fields from user_profile:
def: 28
name: wake_time
type: localtime_into_day
comment: Typical wake time
def: 29
name: sleep_time
type: localtime_into_day
comment: Typical bed time
And two new fields from session:
def: 192
name: workout_feel
type: uint8
comment: A 0-100 scale representing how a user felt while performing a workout. Low values are considered feeling bad, while high values are good.
def: 193
name: workout_rpe
type: uint8
comment: Common Borg CR10 / 0-10 RPE scale, multiplied 10x.. Aggregate score for all workouts in a single session.