Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch for mkdocs version >1.0.4, where 'pages' is now 'nav' #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

catcosmo
Copy link

@catcosmo catcosmo commented Nov 8, 2018

patch for mkdocs version >1.0.4, where 'pages' is now 'nav' in mkdocs.yml file

@catcosmo catcosmo mentioned this pull request Nov 8, 2018
@recklessop
Copy link

Nice, looks like we just need this merged :)

@jgrassler
Copy link
Owner

jgrassler commented Nov 9, 2018

I can merge this but this is pretty much the extent of work I'll still put into this project (I'm not using it anymore, so I no longer have much of an inclination to maintain it). Any of you folks want to take over maintaining it?
Given that you are creating pull requests it's not much of a stretch to assume that you care more about it than I do...

@jgrassler
Copy link
Owner

Also, it's probably better to have a heuristic for both names there, just in case somebody uses the older mkdocs version.

Copy link

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add a >= constraint to the setup.py to exclude older version of mkdocs, no? A modern setuptools will then warn the user that they need to upgrade to avoid this pages/nav issue. See https://github.com/jgrassler/mkdocs-pandoc/blob/master/setup.py#L48.

@decentral1se
Copy link

decentral1se commented May 21, 2019

Any of you folks want to take over maintaining it?

Hi @jgrassler, I can to the extent that I see this is a useful tool for a whole bunch of folks and I am also needing it for a project I am working on. If you want, have a look at my profile here on Github and also PyPi (same username), I have some packages. If you could give me the commit bit here and allow me to make releases (collaborator permissions on PyPi?), I could at least get patches out into the wild.

Please see #31 (comment).

@decentral1se
Copy link

In the meantime, I am working on with:

$ pip install -e git+https://github.com/catcosmo/mkdocs-pandoc.git@issue/29#egg=mkdocs-pandoc

@decentral1se
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants