-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch for mkdocs version >1.0.4, where 'pages' is now 'nav' #30
base: master
Are you sure you want to change the base?
Conversation
Nice, looks like we just need this merged :) |
I can merge this but this is pretty much the extent of work I'll still put into this project (I'm not using it anymore, so I no longer have much of an inclination to maintain it). Any of you folks want to take over maintaining it? |
Also, it's probably better to have a heuristic for both names there, just in case somebody uses the older mkdocs version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add a >=
constraint to the setup.py
to exclude older version of mkdocs
, no? A modern setuptools
will then warn the user that they need to upgrade to avoid this pages/nav issue. See https://github.com/jgrassler/mkdocs-pandoc/blob/master/setup.py#L48.
Please see #31 (comment). |
In the meantime, I am working on with:
|
patch for mkdocs version >1.0.4, where 'pages' is now 'nav' in mkdocs.yml file