fix: dont suggest registering or deleting a checkpoint that is alread…

…y deleted (determined-ai#8246)
jgongd · Oct 25, 2023 · 25adf7d · 25adf7d
1 parent c52ef71
commit 25adf7d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/webui/react/src/components/CheckpointModal.tsx b/webui/react/src/components/CheckpointModal.tsx
@@ -188,6 +188,7 @@ ${checkpoint?.totalBatches}. This action may complete or fail without further no
     <Modal
       cancel
       submit={{
+        disabled: checkpoint?.state === CheckpointState.Deleted,
         handleError,
         handler: handleOk,
         text: 'Register Checkpoint',

diff --git a/webui/react/src/utils/checkpoint.ts b/webui/react/src/utils/checkpoint.ts
@@ -7,17 +7,14 @@ import {
 
 type CheckpointChecker = (checkpoint: CoreApiGenericCheckpoint) => boolean;
 
-/* eslint-disable @typescript-eslint/no-unused-vars */
-export const alwaysTrueCheckpointChecker = (checkpoint: CoreApiGenericCheckpoint): boolean => true;
-
 const CheckpointCheckers: Record<CheckpointAction, CheckpointChecker> = {
   /**
    * for internal use: the typing ensures that checkers
    * are defined for every CheckpointAction
    * we expose the functions below as convenient wrappers
    */
 
-  [checkpointAction.Delete]: alwaysTrueCheckpointChecker,
+  [checkpointAction.Delete]: (checkpoint) => checkpoint.state !== CheckpointState.Deleted,
 
   [checkpointAction.Register]: (checkpoint) => checkpoint.state === CheckpointState.Completed,
 };